yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

The method is huge and has lots of conditional blocks.

We should break the big conditional blocks out into private methods so
the top-level quota_reserve logic can be unit tested on it's own.

This became an issue in this review for a separate bug fix in the logic:

https://review.openstack.org/#/c/121259/

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: db testing

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1369605

Title:
  nova.db.sqlalchemy.api.quota_reserve is not very unit test-able

Status in OpenStack Compute (Nova):
  Triaged

Bug description:
  The method is huge and has lots of conditional blocks.

  We should break the big conditional blocks out into private methods so
  the top-level quota_reserve logic can be unit tested on it's own.

  This became an issue in this review for a separate bug fix in the
  logic:

  https://review.openstack.org/#/c/121259/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1369605/+subscriptions