yahoo-eng-team team mailing list archive

[Patrizio Tufarolo <patriziotufarolo@xxxxxxxxx>]

Public bug reported:

I'm on Nova 2.17.0.
There is a bug in /usr/lib/python2.6/site-packages/nova/volume/encryptors/luks.py at line 89, when it checks for the volume to be a valid luks device.
Instead using that pattern, that looks for a string in english language, you should grab the boolean result of "cryptsetup isLuks".
If the compute node has different locale than english, the "nova volume-attach" command fails.

I have doubts also about the flowchart of the volume attachment operation. If the device is not recognized to be a valid luks device, you are formatting it! So if for some reason the luks header get corrupted,  it erases the whole data.
I think that the process has to be reviewed.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: cinder encryption luks nova volumes

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1372108

Title:
  Attaching LVM encrypted volumes has problems with other locales than
  english

Status in OpenStack Compute (Nova):
  New

Bug description:
  I'm on Nova 2.17.0.
  There is a bug in /usr/lib/python2.6/site-packages/nova/volume/encryptors/luks.py at line 89, when it checks for the volume to be a valid luks device.
  Instead using that pattern, that looks for a string in english language, you should grab the boolean result of "cryptsetup isLuks".
  If the compute node has different locale than english, the "nova volume-attach" command fails.

  I have doubts also about the flowchart of the volume attachment operation. If the device is not recognized to be a valid luks device, you are formatting it! So if for some reason the luks header get corrupted,  it erases the whole data.
  I think that the process has to be reviewed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1372108/+subscriptions