yahoo-eng-team team mailing list archive

[Jacek Świderski <jacek.swiderski@xxxxxxxxx>]

** Also affects: neutron
   Importance: Undecided
       Status: New

** Changed in: neutron
     Assignee: (unassigned) => Jacek Świderski (jacek-swiderski)

** Changed in: neutron
       Status: New => In Progress

** Description changed:

  mock.assert_called_once() is a noop, it doesn't test anything.
  
  Instead it should be mock.assert_called_once_with()
  
  This occurs in the following places:
-   Nova
+   Nova
      nova/tests/virt/hyperv/test_ioutils.py
      nova/tests/virt/libvirt/test_driver.py
-   Cliff
-     cliff/tests/test_app.py
+   Cliff
+     cliff/tests/test_app.py
+   Neutron
+     neutron/tests/unit/services/l3_router/test_l3_apic_plugin.py
+     neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py
+     neutron/tests/unit/test_l3_agent.py
+     neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_sync.py
+     neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_mechanism_driver.py

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1365751

Title:
  Use of assert_called_once() instead of assert_called_once_with()

Status in OpenStack Neutron (virtual network service):
  In Progress
Status in OpenStack Compute (Nova):
  Fix Committed
Status in Command Line Interface Formulation Framework:
  In Progress

Bug description:
  mock.assert_called_once() is a noop, it doesn't test anything.

  Instead it should be mock.assert_called_once_with()

  This occurs in the following places:
    Nova
      nova/tests/virt/hyperv/test_ioutils.py
      nova/tests/virt/libvirt/test_driver.py
    Cliff
      cliff/tests/test_app.py
    Neutron
      neutron/tests/unit/services/l3_router/test_l3_apic_plugin.py
      neutron/tests/unit/services/loadbalancer/drivers/radware/test_plugin_driver.py
      neutron/tests/unit/test_l3_agent.py
      neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_sync.py
      neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_mechanism_driver.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1365751/+subscriptions