yahoo-eng-team team mailing list archive

[Ian Cordasco <icordasc+launchpad@xxxxxxxxxx>]

Public bug reported:

In neutron/tests/unit/test_api_v2.py's APIv2TestCase.test_page_reverse,
there are essentially two tests cases. There is no assertion made for
the second test case here:
https://github.com/openstack/neutron/blob/d3dfbf3e500a30d88f1c08664204dfc118a0154c/neutron/tests/unit/test_api_v2.py#L378..L383

Ostensibly no assertion was made because the pattern is to use
assert_called_once_with, but a mock can be reset, e.g.,  on line 377 you
could write

instance.get_networks.reset_mock()

Such that the pattern could continue to be followed.

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1373126

Title:
  API v2 Test (test_page_reverse) Has No Assertion

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  In neutron/tests/unit/test_api_v2.py's
  APIv2TestCase.test_page_reverse, there are essentially two tests
  cases. There is no assertion made for the second test case here:
  https://github.com/openstack/neutron/blob/d3dfbf3e500a30d88f1c08664204dfc118a0154c/neutron/tests/unit/test_api_v2.py#L378..L383

  Ostensibly no assertion was made because the pattern is to use
  assert_called_once_with, but a mock can be reset, e.g.,  on line 377
  you could write

  instance.get_networks.reset_mock()

  Such that the pattern could continue to be followed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1373126/+subscriptions