← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1373239] [NEW] libvirt: custom video RAM setting in MB but libvirt xml is in blocks of 1024 bytes

 

Public bug reported:

When using this feature
https://review.openstack.org/#/c/63472/
libvirt: Enable custom video RAM setting

I am setting image meta of image

metadata hw_video_model  vga                            
metadata hw_video_ram   64     

As stated "hw_video_ram can be provided via the image properties in Glance.
The value should be provided in MB."
Value should be in MB

also setting flavor-key to
extra_specs                | {"hw_video:ram_max_mb": "65"} 
Also in MB

Booting an instance the xml of the instance ends up like:

 <video>
      <model type='vga' vram='64' heads='1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</video>

But  From
http://libvirt.org/formatdomain.html#elementsVideo
"You can also provide the amount of video memory in kibibytes (blocks of 1024 bytes) using vram and the number of screen with heads."

So this will not give med video ram of 64MB byt 64 bytes.

So if  hw_video_ram  should be in MB conversion to blocks of 1024 bytes
should be done somewhere before output the xml.

Either in 
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py
Or in 
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1373239

Title:
  libvirt: custom video RAM setting in MB but libvirt xml is in blocks
  of 1024 bytes

Status in OpenStack Compute (Nova):
  New

Bug description:
  When using this feature
  https://review.openstack.org/#/c/63472/
  libvirt: Enable custom video RAM setting

  I am setting image meta of image

  metadata hw_video_model  vga                            
  metadata hw_video_ram   64     

  As stated "hw_video_ram can be provided via the image properties in Glance.
  The value should be provided in MB."
  Value should be in MB

  also setting flavor-key to
  extra_specs                | {"hw_video:ram_max_mb": "65"} 
  Also in MB

  Booting an instance the xml of the instance ends up like:

   <video>
        <model type='vga' vram='64' heads='1'/>
        <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
  </video>

  But  From
  http://libvirt.org/formatdomain.html#elementsVideo
  "You can also provide the amount of video memory in kibibytes (blocks of 1024 bytes) using vram and the number of screen with heads."

  So this will not give med video ram of 64MB byt 64 bytes.

  So if  hw_video_ram  should be in MB conversion to blocks of 1024
  bytes should be done somewhere before output the xml.

  Either in 
  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py
  Or in 
  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1373239/+subscriptions


Follow ups

References