← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1375379] [NEW] console: wrong check when verify the server response

 

Public bug reported:

When trying to connect to a console with internal_access_path if the
server does not respond by 200 we should raise an exception but the
current code does not insure this case.

https://github.com/openstack/nova/blob/master/nova/console/websocketproxy.py#L68


The method 'find' return -1 on failure not False or 0

** Affects: nova
     Importance: Undecided
     Assignee: sahid (sahid-ferdjaoui)
         Status: New


** Tags: console

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1375379

Title:
  console: wrong check when verify the server response

Status in OpenStack Compute (Nova):
  New

Bug description:
  When trying to connect to a console with internal_access_path if the
  server does not respond by 200 we should raise an exception but the
  current code does not insure this case.

  https://github.com/openstack/nova/blob/master/nova/console/websocketproxy.py#L68

  
  The method 'find' return -1 on failure not False or 0

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1375379/+subscriptions


Follow ups

References