yahoo-eng-team team mailing list archive

[Thang Pham <thang.g.pham@xxxxxxxxx>]

Public bug reported:

This is a bug reported by Nikola in a review -
https://review.openstack.org/#/c/121965/8/nova/virt/libvirt/driver.py.

swap_volume does not save changes for connection_info.  In swap_volume,
a call is made to _connect_volume, which modifies connection_info.  For
example, in the LibvirtISCSIVolumeDriver,
connection_info['data']['host_device'] = host_device.  However, this
update is not saved to the DB, such that any updates made within
swap_volume are lost.  We need to save any changes made in
_connect_volume to the DB, as it is done elsewhere in the code, e.g.
_get_guest_storage_config
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3488.

** Affects: nova
     Importance: High
     Assignee: Thang Pham (thang-pham)
         Status: New


** Tags: volumes

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1375531

Title:
  swap_volume does not save changes made in _connect_volume

Status in OpenStack Compute (Nova):
  New

Bug description:
  This is a bug reported by Nikola in a review -
  https://review.openstack.org/#/c/121965/8/nova/virt/libvirt/driver.py.

  swap_volume does not save changes for connection_info.  In
  swap_volume, a call is made to _connect_volume, which modifies
  connection_info.  For example, in the LibvirtISCSIVolumeDriver,
  connection_info['data']['host_device'] = host_device.  However, this
  update is not saved to the DB, such that any updates made within
  swap_volume are lost.  We need to save any changes made in
  _connect_volume to the DB, as it is done elsewhere in the code, e.g.
  _get_guest_storage_config
  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3488.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1375531/+subscriptions