yahoo-eng-team team mailing list archive

[Johannes Erdfelt <1378088@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

While looking at some new code, I noticed this test has a bug.

It's easy to reproduce, just remove the call to logging.mask_password
(but keep the LOG.debug) in nova/virt/vmwareapi/vmops.py:spawn. The test
will still pass.

The reason is because failed assertions raise exceptions that are a
subclass of Exception.

The test catches anything derived from Exception and silently ignores
them, including any failed assertions.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1378088

Title:
  nova/tests/virt/vmwareapi/test_vmops:test_spawn_mask_block_device_info_password
  doesn't correctly assert password is scrubbed

Status in OpenStack Compute (Nova):
  New

Bug description:
  While looking at some new code, I noticed this test has a bug.

  It's easy to reproduce, just remove the call to logging.mask_password
  (but keep the LOG.debug) in nova/virt/vmwareapi/vmops.py:spawn. The
  test will still pass.

  The reason is because failed assertions raise exceptions that are a
  subclass of Exception.

  The test catches anything derived from Exception and silently ignores
  them, including any failed assertions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1378088/+subscriptions