yahoo-eng-team team mailing list archive

[Kun Huang <gareth@xxxxxxxxxxxxxxx>]

Public bug reported:

This line[0] should not be "Start a WSGI server in a new green thread."
I think.

The truth is the python process spawn many green threads to handle
incoming request from a greenlet pool. So the WSGI server itself should
be a normal python process[1], but the handling jobs is in green thread
(greenlet). I think we could say "Start a WSGI server with a new green
thread pool" or something else.

Above is from my understanding for os-thread and green thread, maybe
with some mistakes.

[0] https://github.com/openstack/keystone/blob/master/keystone/common/environment/eventlet_server.py#L177
[1] https://github.com/eventlet/eventlet/blob/master/eventlet/wsgi.py#L781-L801

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1380477

Title:
  a tiny issue in docstring

Status in OpenStack Identity (Keystone):
  New

Bug description:
  This line[0] should not be "Start a WSGI server in a new green
  thread." I think.

  The truth is the python process spawn many green threads to handle
  incoming request from a greenlet pool. So the WSGI server itself
  should be a normal python process[1], but the handling jobs is in
  green thread (greenlet). I think we could say "Start a WSGI server
  with a new green thread pool" or something else.

  Above is from my understanding for os-thread and green thread, maybe
  with some mistakes.

  [0] https://github.com/openstack/keystone/blob/master/keystone/common/environment/eventlet_server.py#L177
  [1] https://github.com/eventlet/eventlet/blob/master/eventlet/wsgi.py#L781-L801

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1380477/+subscriptions