yahoo-eng-team team mailing list archive

[Radomir Dopieralski <1384683@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The mocks that have recently been added to the setUp method of the
Openstack Dashboard TestCase have a side effect of registering the
admin.aggregates panel, even if it has been disabled in the
configuration. That's because Mock has to import the module in order to
mock anything inside it, and importing the panel module has a side
effect of registering the panel (the register command is at the top
level of the module code).

This doesn't affect the Dashboard tests, as this panel is already
registered in them. However, in Tuskar-UI we disable all dashboards and
their panels except for the infrastructure dashboard that we are adding.
This leads to url resolution errors when a panel is being registered in
a dashboard that doesn't exist.

** Affects: horizon
     Importance: Critical
     Assignee: Radomir Dopieralski (thesheep)
         Status: In Progress

** Changed in: horizon
   Importance: Undecided => Critical

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1384683

Title:
  Dashboard tests register admin.aggregates as side effect

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  The mocks that have recently been added to the setUp method of the
  Openstack Dashboard TestCase have a side effect of registering the
  admin.aggregates panel, even if it has been disabled in the
  configuration. That's because Mock has to import the module in order
  to mock anything inside it, and importing the panel module has a side
  effect of registering the panel (the register command is at the top
  level of the module code).

  This doesn't affect the Dashboard tests, as this panel is already
  registered in them. However, in Tuskar-UI we disable all dashboards
  and their panels except for the infrastructure dashboard that we are
  adding. This leads to url resolution errors when a panel is being
  registered in a dashboard that doesn't exist.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1384683/+subscriptions