← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1386614] [NEW] A single space verbose_name of data_processing/clusters/tabs InstancesTable is difficult to translate

 

Public bug reported:

(From Transifex issue)

The verbose_name of InstancesTable is just a single space.
It is a string with a single SPACE and it is used to just ignore a name in the code.
It is difficult for translators to understand for translators.

This string has no meaning for translations, so I would suggest to
NOT to mark translatable with a meaningful inline comment.
(Otherwise, we should add a reasonable translators note and contextual marker to the string.)

openstack_dashboard/dashboards/project/data_processing/clusters/tabs.py

class InstancesTable(tables.DataTable):
    name = tables.Column("name",
                         link=("horizon:project:instances:detail"),
                         verbose_name=_("Name"))

    internal_ip = tables.Column("internal_ip",
                                verbose_name=_("Internal IP"))

    management_ip = tables.Column("management_ip",
                                  verbose_name=_("Management IP"))

    class Meta:
        name = "cluster_instances"
        # Just ignoring the name.
        verbose_name = _(" ")

** Affects: horizon
     Importance: Low
         Status: New


** Tags: i18n low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1386614

Title:
  A single space verbose_name of data_processing/clusters/tabs
  InstancesTable is difficult to translate

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  (From Transifex issue)

  The verbose_name of InstancesTable is just a single space.
  It is a string with a single SPACE and it is used to just ignore a name in the code.
  It is difficult for translators to understand for translators.

  This string has no meaning for translations, so I would suggest to
  NOT to mark translatable with a meaningful inline comment.
  (Otherwise, we should add a reasonable translators note and contextual marker to the string.)

  openstack_dashboard/dashboards/project/data_processing/clusters/tabs.py

  class InstancesTable(tables.DataTable):
      name = tables.Column("name",
                           link=("horizon:project:instances:detail"),
                           verbose_name=_("Name"))

      internal_ip = tables.Column("internal_ip",
                                  verbose_name=_("Internal IP"))

      management_ip = tables.Column("management_ip",
                                    verbose_name=_("Management IP"))

      class Meta:
          name = "cluster_instances"
          # Just ignoring the name.
          verbose_name = _(" ")

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1386614/+subscriptions


Follow ups

References