yahoo-eng-team team mailing list archive

[Brian Haley <1398865@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The IPRule code in ip_lib.py doesn't check if a rule already exists, so
it could add a duplicate on agent restart.  For example:

$ sudo ip netns exec qrouter-46460e86-ef11-46fb-8d27-da94435dfcc9 ip rule show
0:	from all lookup local 
32766:	from all lookup main 
32767:	from all lookup default 
167772161:	from 10.0.0.1/24 lookup 167772161 
167772161:	from 10.0.0.1/24 lookup 167772161

It should check first and not add anything if one is already there as
there is no 'replace' option like the routing table has (which will
either update or add).

DVR is currently the only consumer of this code.

** Affects: neutron
     Importance: Undecided
     Assignee: Brian Haley (brian-haley)
         Status: New


** Tags: l3-dvr-backlog

** Changed in: neutron
     Assignee: (unassigned) => Brian Haley (brian-haley)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1398865

Title:
  DVR code can add duplicate routing rules

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  The IPRule code in ip_lib.py doesn't check if a rule already exists,
  so it could add a duplicate on agent restart.  For example:

  $ sudo ip netns exec qrouter-46460e86-ef11-46fb-8d27-da94435dfcc9 ip rule show
  0:	from all lookup local 
  32766:	from all lookup main 
  32767:	from all lookup default 
  167772161:	from 10.0.0.1/24 lookup 167772161 
  167772161:	from 10.0.0.1/24 lookup 167772161

  It should check first and not add anything if one is already there as
  there is no 'replace' option like the routing table has (which will
  either update or add).

  DVR is currently the only consumer of this code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1398865/+subscriptions