yahoo-eng-team team mailing list archive

[Adam Young <1400362@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

In
http://git.openstack.org/cgit/openstack/keystone/tree/keystone/contrib/endpoint_policy/controllers.py#n133


.create_policy_association  should be check_policy_association


 @controller.protected()
    def check_policy_association_for_region_and_service(
            self, context, policy_id, service_id, region_id):
        """Check an association between a policy and region+service."""
        self.policy_api.get_policy(policy_id)
        self.catalog_api.get_service(service_id)
        self.catalog_api.get_region(region_id)
        self.endpoint_policy_api.create_policy_association(
            policy_id, service_id=service_id, region_id=region_id)


create_policy_association(  should be delete_policy_association(

    @controller.protected()
    def delete_policy_association_for_region_and_service(
            self, context, policy_id, service_id, region_id):
        """Delete an association between a policy and region+service."""
        self.policy_api.get_policy(policy_id)
        self.catalog_api.get_service(service_id)
        self.catalog_api.get_region(region_id)
        self.endpoint_policy_api.create_policy_association(
            policy_id, service_id=service_id, region_id=region_id)

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1400362

Title:
  check and delete  policy_association_for_region_and_servce  performs
  create

Status in OpenStack Identity (Keystone):
  New

Bug description:
  In
  http://git.openstack.org/cgit/openstack/keystone/tree/keystone/contrib/endpoint_policy/controllers.py#n133

  
  .create_policy_association  should be check_policy_association

  
   @controller.protected()
      def check_policy_association_for_region_and_service(
              self, context, policy_id, service_id, region_id):
          """Check an association between a policy and region+service."""
          self.policy_api.get_policy(policy_id)
          self.catalog_api.get_service(service_id)
          self.catalog_api.get_region(region_id)
          self.endpoint_policy_api.create_policy_association(
              policy_id, service_id=service_id, region_id=region_id)

  
  create_policy_association(  should be delete_policy_association(

      @controller.protected()
      def delete_policy_association_for_region_and_service(
              self, context, policy_id, service_id, region_id):
          """Delete an association between a policy and region+service."""
          self.policy_api.get_policy(policy_id)
          self.catalog_api.get_service(service_id)
          self.catalog_api.get_region(region_id)
          self.endpoint_policy_api.create_policy_association(
              policy_id, service_id=service_id, region_id=region_id)

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1400362/+subscriptions