yahoo-eng-team team mailing list archive

[Robin Wang <wangbibo@xxxxxxxxxx>]

Public bug reported:

Currently in unit test neutron.tests.unit.openvswitch.test_ovs_tunnel, there're 3 test_daemon_loop test case.
And in each of them, there's a 2 seconds wait according to "polling_interval". It's unnecessary for these test cases,
but introduces extra 6 seconds cost for unit test.

As shown below, these are the top 3 slowest tests in test_ovs_tunnel. Time cost {2.094s, 2.093s, 2.085s}, total 6.272s.
With the patch, time cost reduces to {0.022s, 0.090s, 0.023s}, total 0.135s.


***** without patch ******
Slowest Tests
Test id                                                                                           Runtime (s) 
-----------------------------------------------------------------------------------------------  -----------
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_daemon_loop         2.094
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTest.test_daemon_loop                       2.093
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_daemon_loop                2.085
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_tunnel_update       0.249
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_provision_local_vlan_flat  0.237


***** with patch ******
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_daemon_loop [0.021863s] ... ok
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTest.test_daemon_loop [0.090144s] ... ok
neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_daemon_loop [0.022620s] ... ok

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1401457

Title:
   OVS tunnel UT wastes time on unnecessary time.sleep in daemon_loop

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  Currently in unit test neutron.tests.unit.openvswitch.test_ovs_tunnel, there're 3 test_daemon_loop test case.
  And in each of them, there's a 2 seconds wait according to "polling_interval". It's unnecessary for these test cases,
  but introduces extra 6 seconds cost for unit test.

  As shown below, these are the top 3 slowest tests in test_ovs_tunnel. Time cost {2.094s, 2.093s, 2.085s}, total 6.272s.
  With the patch, time cost reduces to {0.022s, 0.090s, 0.023s}, total 0.135s.

  
  ***** without patch ******
  Slowest Tests
  Test id                                                                                           Runtime (s) 
  -----------------------------------------------------------------------------------------------  -----------
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_daemon_loop         2.094
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTest.test_daemon_loop                       2.093
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_daemon_loop                2.085
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_tunnel_update       0.249
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_provision_local_vlan_flat  0.237

  
  ***** with patch ******
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestUseVethInterco.test_daemon_loop [0.021863s] ... ok
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTest.test_daemon_loop [0.090144s] ... ok
  neutron.tests.unit.openvswitch.test_ovs_tunnel.TunnelTestWithMTU.test_daemon_loop [0.022620s] ... ok

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1401457/+subscriptions