yahoo-eng-team team mailing list archive

[Joris Roovers <1403094@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Using:

PANEL_DASHBOARD = 'settings'
PANEL = 'mypanel'
PANEL_GROUP = "default"
ADD_PANEL = 'mypackage.foo.bar.MyPanel'

Will result in the new panel being added to the "Other" panel group
instead of to the default panelgroup as documented
(http://docs.openstack.org/developer/horizon/topics/settings.html#panel-
group).

This worked fine in icehouse, it looks like this is a regression.

In particular, the following line is throwing an exception (Could not process panel mypanel: type object 'PanelGroup' has no attribute 'panels') because the default panelgroup's __class__ has no panels attribute:
https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L893

Proposed fix: Add the following line on after https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L293
self.__class__.panels = self.panels

A fix in Juno would be nice, because this break existing extensions.

** Affects: horizon
     Importance: Undecided
         Status: New

** Summary changed:

- PANEL_GROUP="default" no longer working in Juno
+ PANEL_GROUP="default" in enabled file no longer working in Juno

** Description changed:

  Using:
  
  PANEL_DASHBOARD = 'settings'
  PANEL = 'mypanel'
  PANEL_GROUP = "default"
  ADD_PANEL = 'mypackage.foo.bar.MyPanel'
  
  Will result in the new panel being added to the "Other" panel group
  instead of to the default panelgroup as documented
  (http://docs.openstack.org/developer/horizon/topics/settings.html#panel-
  group).
  
  This worked fine in icehouse, it looks like this is a regression.
  
  In particular, the following line is throwing an exception (Could not process panel mypanel: type object 'PanelGroup' has no attribute 'panels') because the default panelgroup's __class__ has no panels attribute:
  https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L893
  
+ Proposed fix: Add the following line on after https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L293
+ self.__class__.panels = self.panels
+ 
  A fix in Juno would be nice, because this break existing extensions.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1403094

Title:
  PANEL_GROUP="default" in enabled file no longer working in Juno

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Using:

  PANEL_DASHBOARD = 'settings'
  PANEL = 'mypanel'
  PANEL_GROUP = "default"
  ADD_PANEL = 'mypackage.foo.bar.MyPanel'

  Will result in the new panel being added to the "Other" panel group
  instead of to the default panelgroup as documented
  (http://docs.openstack.org/developer/horizon/topics/settings.html
  #panel-group).

  This worked fine in icehouse, it looks like this is a regression.

  In particular, the following line is throwing an exception (Could not process panel mypanel: type object 'PanelGroup' has no attribute 'panels') because the default panelgroup's __class__ has no panels attribute:
  https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L893

  Proposed fix: Add the following line on after https://github.com/openstack/horizon/blame/stable/juno/horizon/base.py#L293
  self.__class__.panels = self.panels

  A fix in Juno would be nice, because this break existing extensions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1403094/+subscriptions