yahoo-eng-team team mailing list archive

[Joe Gordon <1403270@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

As of https://review.openstack.org/#/c/140146/2 importing
nova.hacking.checks now requires eventlet

This becomes an issue if we want to run flake8 in a venv without
eventlet.  We do this as part of the hacking integration test, it builds
a venv (via tox) with trunk hacking and runs flake8 on other
repositories to help check for issues.

A few possible ways to resolve this:

* revert https://review.openstack.org/#/c/140146/2
* Add eventlet to the hacking integration test
* move hacking checks outside of nova/*

For now going with the second option.

Stacktrace: http://logs.openstack.org/52/134052/5/check//gate-hacking-
integration-nova/c4d107b/console.html#_2014-12-16_22_38_03_070


>>> import nova.hacking.checks.factory
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "nova/__init__.py", line 30, in <module>
    import eventlet  # noqa
ImportError: No module named eventlet

** Affects: hacking
     Importance: Undecided
         Status: New

** Affects: nova
     Importance: Undecided
         Status: New

** Description changed:

  As of https://review.openstack.org/#/c/140146/2 importing
  nova.hacking.checks now requires eventlet
  
  This becomes an issue if we want to run flake8 in a venv without
  eventlet.  We do this as part of the hacking integration test, it builds
  a venv (via tox) with trunk hacking and runs flake8 on other
  repositories to help check for issues.
  
  A few possible ways to resolve this:
  
  * revert https://review.openstack.org/#/c/140146/2
  * Add eventlet to the hacking integration test
  * move hacking checks outside of nova/*
  
  For now going with the second option.
+ 
+ Stacktrace: http://logs.openstack.org/52/134052/5/check//gate-hacking-
+ integration-nova/c4d107b/console.html#_2014-12-16_22_38_03_070
+ 
+ 
+ >>> import nova.hacking.checks.factory
+ Traceback (most recent call last):
+   File "<stdin>", line 1, in <module>
+   File "nova/__init__.py", line 30, in <module>
+     import eventlet  # noqa
+ ImportError: No module named eventlet

** Also affects: hacking
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1403270

Title:
  "import nova.hacking.checks.factory" now requires eventlet

Status in OpenStack Hacking Guidelines:
  New
Status in OpenStack Compute (Nova):
  New

Bug description:
  As of https://review.openstack.org/#/c/140146/2 importing
  nova.hacking.checks now requires eventlet

  This becomes an issue if we want to run flake8 in a venv without
  eventlet.  We do this as part of the hacking integration test, it
  builds a venv (via tox) with trunk hacking and runs flake8 on other
  repositories to help check for issues.

  A few possible ways to resolve this:

  * revert https://review.openstack.org/#/c/140146/2
  * Add eventlet to the hacking integration test
  * move hacking checks outside of nova/*

  For now going with the second option.

  Stacktrace: http://logs.openstack.org/52/134052/5/check//gate-hacking-
  integration-nova/c4d107b/console.html#_2014-12-16_22_38_03_070


  >>> import nova.hacking.checks.factory
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
    File "nova/__init__.py", line 30, in <module>
      import eventlet  # noqa
  ImportError: No module named eventlet

To manage notifications about this bug go to:
https://bugs.launchpad.net/hacking/+bug/1403270/+subscriptions