← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1406172] [NEW] the code of get_token_provider in token.provider.py does not match docstring

 

Public bug reported:

The docstring says "Return the provider based on ``token_format`` if
``provider`` is not set. Otherwise, ignore ``token_format`` and return
the configured ``provider`` instead.", refer to:
https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L127

However, the codes check CONF.signing.token_format first and then check
CONF.token.provide.

** Affects: keystone
     Importance: Undecided
     Assignee: wanghong (w-wanghong)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => wanghong (w-wanghong)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1406172

Title:
  the code of get_token_provider in token.provider.py does not match
  docstring

Status in OpenStack Identity (Keystone):
  New

Bug description:
  The docstring says "Return the provider based on ``token_format`` if
  ``provider`` is not set. Otherwise, ignore ``token_format`` and return
  the configured ``provider`` instead.", refer to:
  https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L127

  However, the codes check CONF.signing.token_format first and then
  check CONF.token.provide.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1406172/+subscriptions


Follow ups

References