yahoo-eng-team team mailing list archive

[Wu Hong Guang <1410684@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

the file openstack_dashboard/test/integration_tests/helpers.py

https://review.openstack.org/gitweb?p=openstack/horizon.git;a=blob;f=openstack_dashboard/test/integration_tests/helpers.py;h=8e7da7a8a51c03f24db58bfd3e016d8c52224384;hb=refs/heads/master


the 2 reasons why it should be remove:


1:  The only difference between TestCase and AdminTestCase is
     the call of login(),
      the former uses the default parameters and latter use admin

2: the decision of which user will be login  should be left to test case
designer,

     and in complicated test case we need admin and ordinary use work
cooperately

    so in the test case setup ,it's not necessary to do login actually

class TestCase(BaseTestCase):

    def setUp(self):
        super(TestCase, self).setUp()
        self.login_pg = loginpage.LoginPage(self.driver, self.conf)
        self.login_pg.go_to_login_page()
        

    def tearDown(self):
        self.home_pg.go_to_home_page()
        self.home_pg.log_out()
        super(TestCase, self).tearDown()

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1410684

Title:
  AdminTestCase is duplicated and should be removed

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  the file openstack_dashboard/test/integration_tests/helpers.py

  https://review.openstack.org/gitweb?p=openstack/horizon.git;a=blob;f=openstack_dashboard/test/integration_tests/helpers.py;h=8e7da7a8a51c03f24db58bfd3e016d8c52224384;hb=refs/heads/master


  the 2 reasons why it should be remove:


  1:  The only difference between TestCase and AdminTestCase is
       the call of login(),
        the former uses the default parameters and latter use admin

  2: the decision of which user will be login  should be left to test
  case designer,

       and in complicated test case we need admin and ordinary use work
  cooperately

      so in the test case setup ,it's not necessary to do login actually

  class TestCase(BaseTestCase):

      def setUp(self):
          super(TestCase, self).setUp()
          self.login_pg = loginpage.LoginPage(self.driver, self.conf)
          self.login_pg.go_to_login_page()
          

      def tearDown(self):
          self.home_pg.go_to_home_page()
          self.home_pg.log_out()
          super(TestCase, self).tearDown()

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1410684/+subscriptions