yahoo-eng-team team mailing list archive

[Rob Cresswell <rcresswe@xxxxxxxxx>]

Public bug reported:

The naming schemes for imports are hugely inconsistent. In Admin Router
views, imports have names like 'rtabs', while in Admin Network Ports
views we use 'project_forms' to refer to the Admin Port forms, and then
in Admin Project views we just use 'views'. The imports should be named
logically to make the code base more readable, without having to
doublecheck imports each time.

- Admin Router views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/routers/views.py
- Admin Network Ports views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/networks/ports/views.py
- Admin Project views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/views.py

** Affects: horizon
     Importance: Undecided
     Assignee: Rob Cresswell (robcresswell)
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1411037

Title:
  Inconsistent import naming

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  The naming schemes for imports are hugely inconsistent. In Admin
  Router views, imports have names like 'rtabs', while in Admin Network
  Ports views we use 'project_forms' to refer to the Admin Port forms,
  and then in Admin Project views we just use 'views'. The imports
  should be named logically to make the code base more readable, without
  having to doublecheck imports each time.

  - Admin Router views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/routers/views.py
  - Admin Network Ports views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/networks/ports/views.py
  - Admin Project views.py: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/instances/views.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1411037/+subscriptions