yahoo-eng-team team mailing list archive

[Jay Pipes <1414515@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The zookeeper servicegroup driver's join() method returns a
FakeLoopingCall for no reason whatsoever:

class FakeLoopingCall(loopingcall.LoopingCallBase):
    """The fake Looping Call implementation, created for backward
    compatibility with a membership based on DB.
    """
    def __init__(self, driver, host, group):
        self._driver = driver
        self._group = group
        self._host = host

    def stop(self):
        self._driver.leave(self._host, self._group)

    def start(self, interval, initial_delay=None):
        pass

    def wait(self):
        pass

The rest of the drivers just return None, so this is not necessary.

** Affects: nova
     Importance: Low
     Assignee: Jay Pipes (jaypipes)
         Status: In Progress


** Tags: low-hanging-fruit servicegroup-api

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1414515

Title:
  Zookeeper servicegroup driver's join() method returns a
  FakeLoopingCall

Status in OpenStack Compute (Nova):
  In Progress

Bug description:
  The zookeeper servicegroup driver's join() method returns a
  FakeLoopingCall for no reason whatsoever:

  class FakeLoopingCall(loopingcall.LoopingCallBase):
      """The fake Looping Call implementation, created for backward
      compatibility with a membership based on DB.
      """
      def __init__(self, driver, host, group):
          self._driver = driver
          self._group = group
          self._host = host

      def stop(self):
          self._driver.leave(self._host, self._group)

      def start(self, interval, initial_delay=None):
          pass

      def wait(self):
          pass

  The rest of the drivers just return None, so this is not necessary.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1414515/+subscriptions