← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1416583] [NEW] Policy check is missing outer parens

 

Public bug reported:

The policy check call seems to be missing another set of parens and a
comma resulting in incorrect parsing of the action in the policy.py


https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L147

....
 user = request.user
    if admin:
        if not policy.check(("identity", "admin_required"), request):
            raise exceptions.NotAuthorized
        endpoint_type = 'adminURL'
....

** Affects: horizon
     Importance: Undecided
     Assignee: Dan Nguyen (daniel-a-nguyen)
         Status: In Progress

** Changed in: horizon
     Assignee: (unassigned) => Dan Nguyen (daniel-a-nguyen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1416583

Title:
  Policy check is missing outer parens

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  The policy check call seems to be missing another set of parens and a
  comma resulting in incorrect parsing of the action in the policy.py

  
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L147

  ....
   user = request.user
      if admin:
          if not policy.check(("identity", "admin_required"), request):
              raise exceptions.NotAuthorized
          endpoint_type = 'adminURL'
  ....

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1416583/+subscriptions


Follow ups

References