yahoo-eng-team team mailing list archive

[wanghong <w.wanghong@xxxxxxxxxx>]

Public bug reported:

In token.persistence.core:PersistenceManager.delete_tokens method, we would:
1. List tokens that going to be deleted
2. Delete tokens, note that here we wouldn't use the data got before
3. Loop the tokens got before and invalidate token cache
There are two issues here:
1. Tokens got before may not equal with tokens that deleted
2. According to current code, we do list twice both in sql and kvs backends
Refer to:
https://github.com/openstack/keystone/blob/master/keystone/token/persistence/core.py#L116

** Affects: keystone
     Importance: Undecided
     Assignee: wanghong (w-wanghong)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => wanghong (w-wanghong)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1418868

Title:
  duplicate operations when deleting tokens

Status in OpenStack Identity (Keystone):
  New

Bug description:
  In token.persistence.core:PersistenceManager.delete_tokens method, we would:
  1. List tokens that going to be deleted
  2. Delete tokens, note that here we wouldn't use the data got before
  3. Loop the tokens got before and invalidate token cache
  There are two issues here:
  1. Tokens got before may not equal with tokens that deleted
  2. According to current code, we do list twice both in sql and kvs backends
  Refer to:
  https://github.com/openstack/keystone/blob/master/keystone/token/persistence/core.py#L116

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1418868/+subscriptions