← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1419042] [NEW] os.makedirs with 0o7755 was repeated several places in agent code

 

Public bug reported:

For agent code,  os.makedirs(dir, 0o755) was repeated in several places.
First it will be difficult if we want to modify file permission such as 0o555 in the future.
It will be easier to just to agent.linux.utils.ensure_dir method in other plances.
Second, there is no unit test for utils.os.ensure_dir method. We need to add unit testing.

** Affects: neutron
     Importance: Undecided
     Assignee: Zengfa Gao (zfgao)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Zengfa Gao (zfgao)

** Summary changed:

- os.makedirs with 0o7755 was repeated several plances in agent code
+ os.makedirs with 0o7755 was repeated several places in agent code

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1419042

Title:
  os.makedirs with 0o7755 was repeated several places in agent code

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  For agent code,  os.makedirs(dir, 0o755) was repeated in several places.
  First it will be difficult if we want to modify file permission such as 0o555 in the future.
  It will be easier to just to agent.linux.utils.ensure_dir method in other plances.
  Second, there is no unit test for utils.os.ensure_dir method. We need to add unit testing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1419042/+subscriptions


Follow ups

References