yahoo-eng-team team mailing list archive

["Chris St. Pierre" <1421017@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When launching an instance, Horizon does some checks to ensure that the
flavor the user has chosen is large enough to support the image they
have chosen. Unfortunately:

1. These checks are broken. For disk size, they only check the
`min_disk` property of the image, not the image size or virtual size; as
a result, the image disk size is only checked in practice if the user
has bothered to set the `min_disk` property.

2. The unit tests for the checks are broken. They modify local versions
of the glance image data, but then run the tests by passing image IDs,
which means that the original unmodified test images are used. The tests
happen to pass, accidentally, but they don't test what we think they're
testing.

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1421017

Title:
  Flavor/image size checks are insufficient and untested

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  When launching an instance, Horizon does some checks to ensure that
  the flavor the user has chosen is large enough to support the image
  they have chosen. Unfortunately:

  1. These checks are broken. For disk size, they only check the
  `min_disk` property of the image, not the image size or virtual size;
  as a result, the image disk size is only checked in practice if the
  user has bothered to set the `min_disk` property.

  2. The unit tests for the checks are broken. They modify local
  versions of the glance image data, but then run the tests by passing
  image IDs, which means that the original unmodified test images are
  used. The tests happen to pass, accidentally, but they don't test what
  we think they're testing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1421017/+subscriptions