yahoo-eng-team team mailing list archive

[Assaf Muller <amuller@xxxxxxxxxx>]

Public bug reported:

https://github.com/openstack/neutron-
fwaas/blob/master/neutron_fwaas/services/firewall/agents/varmour/varmour_router.py#L64

vArmour L3 agent _router_added is calling
neutron.agent.l3.router_info.RouterInfo__init__ and its not passing
mandatory parameters (interface_driver, agent_conf). These parameters
were introduced in change IDs:

I33a23eb37678d94cea3ace8afe090935b1e70685
I0ec75d731d816955c1915e283a137abcb51ac232

The unit tests that would catch this error:

https://github.com/openstack/neutron-
fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L153

Are being skipped at the gate (Which is essentially another bug, why do these unit tests require a REST call to succeed, and are failing to complete the REST call with the default configuration?)
https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L182

Finally, 3rd party vArmour CI is not being run.

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1427465

Title:
  vArmour fwaas agent broken, unit tests skipped, CI not running

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  https://github.com/openstack/neutron-
  fwaas/blob/master/neutron_fwaas/services/firewall/agents/varmour/varmour_router.py#L64

  vArmour L3 agent _router_added is calling
  neutron.agent.l3.router_info.RouterInfo__init__ and its not passing
  mandatory parameters (interface_driver, agent_conf). These parameters
  were introduced in change IDs:

  I33a23eb37678d94cea3ace8afe090935b1e70685
  I0ec75d731d816955c1915e283a137abcb51ac232

  The unit tests that would catch this error:

  https://github.com/openstack/neutron-
  fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L153

  Are being skipped at the gate (Which is essentially another bug, why do these unit tests require a REST call to succeed, and are failing to complete the REST call with the default configuration?)
  https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/tests/unit/services/firewall/drivers/varmour/test_varmour_fwaas.py#L182

  Finally, 3rd party vArmour CI is not being run.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1427465/+subscriptions