yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

We already get a neutronclient object once at the beginning of this
method when we're getting the list of ports, we don't need to get it
again every time we're in the loop for the ports to update them:

http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n803

** Affects: nova
     Importance: Low
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: low-hanging-fruit neutron

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1430481

Title:
  neutronv2 API: remove_fixed_ip_from_instance constructs a client for
  each port in the loop

Status in OpenStack Compute (Nova):
  Triaged

Bug description:
  We already get a neutronclient object once at the beginning of this
  method when we're getting the list of ports, we don't need to get it
  again every time we're in the loop for the ports to update them:

  http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n803

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1430481/+subscriptions