yahoo-eng-team team mailing list archive

[Rick Harris <rick.harris@xxxxxxxxxxxxx>]

Public bug reported:

The auth tests used a stub to alter `nova.RequestContext` to become
`FakeRequestContext`. The problem with this is that `FakeRequestContext`
inherits from `nova.RequestContext` which has the effect of making
`FakeRequestContext` point to itself for it's parent class.

This leads to infinite recursion if a context object is created after this
stub is set.

This code has worked up until now because no tests have created a new context
after this stub was set. Downstream patches, however, may end up creating a
context here, so we should fix this.

It turns out that this stub isn't necessary, so deleting it entirely is
sufficient to fix the issue and keep tests passing.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1431022

Title:
  Infinite recursion possible with test_auth test

Status in OpenStack Compute (Nova):
  New

Bug description:
  The auth tests used a stub to alter `nova.RequestContext` to become
  `FakeRequestContext`. The problem with this is that `FakeRequestContext`
  inherits from `nova.RequestContext` which has the effect of making
  `FakeRequestContext` point to itself for it's parent class.

  This leads to infinite recursion if a context object is created after this
  stub is set.

  This code has worked up until now because no tests have created a new context
  after this stub was set. Downstream patches, however, may end up creating a
  context here, so we should fix this.

  It turns out that this stub isn't necessary, so deleting it entirely is
  sufficient to fix the issue and keep tests passing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1431022/+subscriptions