← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1431519] [NEW] nova.tests.unit.network.test_neutronv2.TestNeutronv2WithMock.test_deallocate_for_instance_uses_delete_helper fails with sqlalchemy.exc.OperationalError

 

Public bug reported:

Due to this change:

https://github.com/openstack/nova/commit/92074e0fde7da6262897b08d100fedcfe7e4940f

I'm always hitting this locally now:

http://paste.openstack.org/show/191892/

Looking at the code, I don't see how it wouldn't fail since the
neutronv2 API code calls base_api.update_instance_cache_with_nw_info
which eventually calls instance.save() and the
nova.objects.Instance.save() method isn't mocked out, which talks to the
DB API and that blows up since we don't have a database connection.

I'm not sure how this is passing in the gate, but looking at the code
it's clearly wrong.  There must be some test ordering issue that makes
this pass.

** Affects: nova
     Importance: Undecided
     Assignee: Matt Riedemann (mriedem)
         Status: In Progress


** Tags: testing

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1431519

Title:
  nova.tests.unit.network.test_neutronv2.TestNeutronv2WithMock.test_deallocate_for_instance_uses_delete_helper
  fails with sqlalchemy.exc.OperationalError

Status in OpenStack Compute (Nova):
  In Progress

Bug description:
  Due to this change:

  https://github.com/openstack/nova/commit/92074e0fde7da6262897b08d100fedcfe7e4940f

  I'm always hitting this locally now:

  http://paste.openstack.org/show/191892/

  Looking at the code, I don't see how it wouldn't fail since the
  neutronv2 API code calls base_api.update_instance_cache_with_nw_info
  which eventually calls instance.save() and the
  nova.objects.Instance.save() method isn't mocked out, which talks to
  the DB API and that blows up since we don't have a database
  connection.

  I'm not sure how this is passing in the gate, but looking at the code
  it's clearly wrong.  There must be some test ordering issue that makes
  this pass.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1431519/+subscriptions


Follow ups

References