← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1418017] Re: wrong import of novaclient modules in neutron.notifiers.nova

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

** Changed in: neutron
    Milestone: None => kilo-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1418017

Title:
  wrong import of novaclient modules in neutron.notifiers.nova

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  Module neutron.notifiers.nova has direct imports of modules from
  novaclient.v1_1[1]. This is wrong way, which produced a blocker for
  versioning stuff in novaclient(see [3] for more details).

  novaclient object should be obtained via interface in novaclient[3]. 
  Obtaining of contrib modules should be implemented based on novaclient object, so versioning stuff will be left in novaclient repo.

  [1] - https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L18-L19
  [2] - https://review.openstack.org/#/c/149006/
  [3] - https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L791

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1418017/+subscriptions


References