← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1418017] [NEW] wrong import of client module of novaclient

 

Public bug reported:

Module neutron.notifiers.nova has a direct import of novaclient.v1_1.client[1], which is used only for initialization a client of nova[2].
This is wrong way, which produced a blocker for versioning stuff in novaclient(see [3] for more details).

Novaclient provide a correct way to get client object[4], which neutron
should use.


[1] - https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L18
[2] - https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L51
[3] - https://review.openstack.org/#/c/149006/
[4] - https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L791

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1418017

Title:
  wrong import of client module of novaclient

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  Module neutron.notifiers.nova has a direct import of novaclient.v1_1.client[1], which is used only for initialization a client of nova[2].
  This is wrong way, which produced a blocker for versioning stuff in novaclient(see [3] for more details).

  Novaclient provide a correct way to get client object[4], which
  neutron should use.


  [1] - https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L18
  [2] - https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L51
  [3] - https://review.openstack.org/#/c/149006/
  [4] - https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L791

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1418017/+subscriptions


Follow ups

References