← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1435748] [NEW] save method is getting called two times in 'attach' api

 

Public bug reported:


'save' method is getting called two times in 'attach' method of class 'DriverVolumeBlockDevice'.
(https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L224)
It is getting called from decorator 'update_db' and from attach method itself.

There is no need of decorator 'update_db' for attach method as 'save' is already 
called in attach method.

Note: save method will not update db if there is no change in bdm object

** Affects: nova
     Importance: Undecided
     Assignee: Abhijeet Malawade (abhijeet-malawade)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Abhijeet Malawade (abhijeet-malawade)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1435748

Title:
  save method is getting called two times in 'attach' api

Status in OpenStack Compute (Nova):
  New

Bug description:
  
  'save' method is getting called two times in 'attach' method of class 'DriverVolumeBlockDevice'.
  (https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L224)
  It is getting called from decorator 'update_db' and from attach method itself.

  There is no need of decorator 'update_db' for attach method as 'save' is already 
  called in attach method.

  Note: save method will not update db if there is no change in bdm
  object

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1435748/+subscriptions


Follow ups

References