yahoo-eng-team team mailing list archive

[Bartosz Fic <bartosz.fic@xxxxxxxxx>]

Public bug reported:

In this file: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L600
Implementing _set_vm_state() method in _live_migrate() method is unnecessary.

It could be used method from line #590:

def _set_vm_state_and_notify(self, context, instance_uuid, method, updates, ex, request_spec):
    scheduler_utils.set_vm_state_and_notify(
        context, instance_uuid, 'compute_task', 
         method, updates,ex, request_spec, self.db)

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: low-hanging-fruit

** Tags added: low-hanging-fruit

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1438093

Title:
  Redundant method _set_vm_state in conductor _live_migrate

Status in OpenStack Compute (Nova):
  New

Bug description:
  In this file: https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L600
  Implementing _set_vm_state() method in _live_migrate() method is unnecessary.

  It could be used method from line #590:

  def _set_vm_state_and_notify(self, context, instance_uuid, method, updates, ex, request_spec):
      scheduler_utils.set_vm_state_and_notify(
          context, instance_uuid, 'compute_task', 
           method, updates,ex, request_spec, self.db)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1438093/+subscriptions