yahoo-eng-team team mailing list archive

[Lin Hua Cheng <1443721@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code for checking if Trust exists is duplicated all over the
controller:

if not trust:
    raise exception.TrustNotFound(trust_id=trust_id)

https://github.com/openstack/keystone/blob/master/keystone/trust/controllers.py#L77-L78

to make it more DRY, remove the check in controller and move it the
driver

** Affects: keystone
     Importance: Undecided
         Status: New

** Summary changed:

- Move duplicated checking if Trust exists to the driver
+ Move duplicated checking of Trust existence from controller to driver

** Summary changed:

- Move duplicated checking of Trust existence from controller to driver
+ Make checking of Trust existence more DRY

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1443721

Title:
  Make checking of Trust existence more DRY

Status in OpenStack Identity (Keystone):
  New

Bug description:
  The code for checking if Trust exists is duplicated all over the
  controller:

  if not trust:
      raise exception.TrustNotFound(trust_id=trust_id)

  https://github.com/openstack/keystone/blob/master/keystone/trust/controllers.py#L77-L78

  to make it more DRY, remove the check in controller and move it the
  driver

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1443721/+subscriptions