yahoo-eng-team team mailing list archive

[Stephen Ma <stephen.ma@xxxxxx>]

Public bug reported:

On the stable/juno branch, https://review.openstack.org/#/c/164329
(ChangeId: I3ad7864eeb2f959549ed356a1e34fa18804395cc, fixed bug
https://bugs.launchpad.net/neutron/+bug/1414218) was merged on April
1st.  Less than 1 hour before this merge,
https://review.openstack.org/#/c/153181 was merged.  Both patches
modified the same function _output_hosts_file() in the same file
(neutron/agent/linux/dhcp.py).  https://review.openstack.org/#/c/164329
removed LOG.debug statements from the _output_hosts_file while
https://review.openstack.org/#/c/153181 added LOG.debug statements. The
end result is that the bad performance problem fixed by
https://review.openstack.org/#/c/164329 is reverted by
https://review.openstack.org/#/c/153181 unintentionally.

The https://review.openstack.org/#/c/164329 fixes bug
https://bugs.launchpad.net/neutron/+bug/1414218. The root cause is the
performance overhead due to the LOG.debug statements in the for-loop of
the _output_hosts_file() function.

This problem is only found on the stable/juno branch of neutron.

** Affects: neutron
     Importance: Undecided
     Assignee: Stephen Ma (stephen-ma)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Stephen Ma (stephen-ma)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1445202

Title:
  Bug #1414218 is not fixed on the stable/juno branch

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  On the stable/juno branch, https://review.openstack.org/#/c/164329
  (ChangeId: I3ad7864eeb2f959549ed356a1e34fa18804395cc, fixed bug
  https://bugs.launchpad.net/neutron/+bug/1414218) was merged on April
  1st.  Less than 1 hour before this merge,
  https://review.openstack.org/#/c/153181 was merged.  Both patches
  modified the same function _output_hosts_file() in the same file
  (neutron/agent/linux/dhcp.py).
  https://review.openstack.org/#/c/164329 removed LOG.debug statements
  from the _output_hosts_file while
  https://review.openstack.org/#/c/153181 added LOG.debug statements.
  The end result is that the bad performance problem fixed by
  https://review.openstack.org/#/c/164329 is reverted by
  https://review.openstack.org/#/c/153181 unintentionally.

  The https://review.openstack.org/#/c/164329 fixes bug
  https://bugs.launchpad.net/neutron/+bug/1414218. The root cause is the
  performance overhead due to the LOG.debug statements in the for-loop
  of the _output_hosts_file() function.

  This problem is only found on the stable/juno branch of neutron.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1445202/+subscriptions