yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #32236
[Bug 1444584] Re: Jshint should ignore library code before enabling undef or unused
** Changed in: horizon
Status: Fix Committed => Invalid
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1444584
Title:
Jshint should ignore library code before enabling undef or unused
Status in OpenStack Dashboard (Horizon):
Invalid
Bug description:
Ignoring jshint on legacy JS code
Once undef and unused are enabled, legacy and library code will throw
over 365 errors. Remember that undef check for undefined variables
while unused checks for unused variables, both are good for quality
control.
We have two options going forward:
1. Clean up legacy code
2. Ignore legacy code
Based on discussion in IRC, looks like we are going with option one.
However, we still need to disable checks in 3rd party libraries.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1444584/+subscriptions
References