yahoo-eng-team team mailing list archive

[Thai Tran <tqtran@xxxxxxxxxx>]

Public bug reported:

Ignoring jshint on legacy JS code

Once undef and unused are enabled, legacy code will throw over 365
errors. Remember that undef check for undefined variables while unused
checks for unused variables, both are good for quality control.

We have two options going forward:
1. Clean up legacy code
2. Ignore legacy code

Since legacy is stable enough, cleaning it up might have higher risk of
regression and does not improve code or add value. We should ignore
legacy code base on this reasoning.

** Affects: horizon
     Importance: Medium
     Assignee: Thai Tran (tqtran)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1444584

Title:
  Jshint should ignore legacy code before enabling undef or unused

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  Ignoring jshint on legacy JS code

  Once undef and unused are enabled, legacy code will throw over 365
  errors. Remember that undef check for undefined variables while unused
  checks for unused variables, both are good for quality control.

  We have two options going forward:
  1. Clean up legacy code
  2. Ignore legacy code

  Since legacy is stable enough, cleaning it up might have higher risk
  of regression and does not improve code or add value. We should ignore
  legacy code base on this reasoning.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1444584/+subscriptions