yahoo-eng-team team mailing list archive

[Aishwarya Thangappa <aishwarya.thangappa@xxxxxxxxx>]

Public bug reported:

Please take a look at "test_create_listener_empty_tenant_id" method in
test_listeners_admin.py in the patch
https://review.openstack.org/#/c/173423 to reproduce the error.


Ongoing discussion:
--------------------------------
In case of  noop driver when we try to create a resource(loadbalancer/listener/member/pool) with empty tenant id, it gets created (as there is no validation). But in case of backend driver with validation for empty/invalid tenant-id, it raises BadRequest which is translated as "driver-internal error" at plugin layer.
-Santosh Sharma

I think the question would be whether the api should treat an empty string tenant id the same as a tenant id which is None.
-Franklin Naval

I think this falls under the same discussion about tenant_id being validated for all admin requests. All of neutron currently does not do this, and since we are an extension to neutron and don't control the wsgi layer, we usually just go with what they do. However, we can specifically validate the string is non-empty in our plugin, but that would be a temporary hack until the larger neutron discussion completes.
-Brandon Logan

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: neutron-lbaas

** Tags added: neutron-lbaas

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1451621

Title:
  creating resources with an empty tenant_id succeeds when using noop
  driver

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  Please take a look at "test_create_listener_empty_tenant_id" method in
  test_listeners_admin.py in the patch
  https://review.openstack.org/#/c/173423 to reproduce the error.

  
  Ongoing discussion:
  --------------------------------
  In case of  noop driver when we try to create a resource(loadbalancer/listener/member/pool) with empty tenant id, it gets created (as there is no validation). But in case of backend driver with validation for empty/invalid tenant-id, it raises BadRequest which is translated as "driver-internal error" at plugin layer.
  -Santosh Sharma

  I think the question would be whether the api should treat an empty string tenant id the same as a tenant id which is None.
  -Franklin Naval

  I think this falls under the same discussion about tenant_id being validated for all admin requests. All of neutron currently does not do this, and since we are an extension to neutron and don't control the wsgi layer, we usually just go with what they do. However, we can specifically validate the string is non-empty in our plugin, but that would be a temporary hack until the larger neutron discussion completes.
  -Brandon Logan

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1451621/+subscriptions