← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1451910] [NEW] Use single connection in get_all function for getting "enabled" values for all ldap users.

 

Public bug reported:

LDAP being enabled, any keystone commands that use get_all takes a lot
of time, especially if there are many LDAP users (like ~3000), due to
the fact that _get_enabled makes a new connection for each user.
Instead, I thought it would be better if a connection is made before the
for loop in get_all, get all "enabled" values from all users, and then
close the connection. I actually tested this code change on mine, and it
actually speeds up many keystone commands (user-list, user-role-add,
user-delete, user-get). Before it took about 50 seconds, but now, it
takes about 4 seconds.

** Affects: keystone
     Importance: Undecided
     Assignee: Min Song (ms2597)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => Min Song (ms2597)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1451910

Title:
  Use single connection in get_all function for getting "enabled" values
  for all ldap users.

Status in OpenStack Identity (Keystone):
  New

Bug description:
  LDAP being enabled, any keystone commands that use get_all takes a lot
  of time, especially if there are many LDAP users (like ~3000), due to
  the fact that _get_enabled makes a new connection for each user.
  Instead, I thought it would be better if a connection is made before
  the for loop in get_all, get all "enabled" values from all users, and
  then close the connection. I actually tested this code change on mine,
  and it actually speeds up many keystone commands (user-list, user-
  role-add, user-delete, user-get). Before it took about 50 seconds, but
  now, it takes about 4 seconds.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1451910/+subscriptions


Follow ups

References