yahoo-eng-team team mailing list archive

[Rob Cresswell <rcresswe@xxxxxxxxx>]

Public bug reported:

Modals are reduced size, so are causing some ugly text-wrap. This was
caused by this patch: https://review.openstack.org/#/c/184595 which
needs to be reverted.

>From the docs:

"This means that if the variable has already been assigned to, it won't
be re-assigned, but if it doesn't have a value yet, it will be given
one."

The problem here is that because modal-md already has a default value,
the new default isn't applying.

jsfiddle example of default not overriding another default: http://jsfiddle.net/robcresswell/gop052kk/
Reference: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#variable_defaults_

** Affects: horizon
     Importance: Undecided
     Assignee: Rob Cresswell (robcresswell)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1459573

Title:
  Modal size is incorrect

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  Modals are reduced size, so are causing some ugly text-wrap. This was
  caused by this patch: https://review.openstack.org/#/c/184595 which
  needs to be reverted.

  From the docs:

  "This means that if the variable has already been assigned to, it
  won't be re-assigned, but if it doesn't have a value yet, it will be
  given one."

  The problem here is that because modal-md already has a default value,
  the new default isn't applying.

  jsfiddle example of default not overriding another default: http://jsfiddle.net/robcresswell/gop052kk/
  Reference: http://sass-lang.com/documentation/file.SASS_REFERENCE.html#variable_defaults_

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1459573/+subscriptions