← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1459782] [NEW] _is_storage_shared_with() in libvirt/driver.py gives possibly false results if ssh keys not configured

 

Public bug reported:

In virt.libvirt.driver.LibvirtDriver._is_storage_shared_with() we first
check IP addresses and if they don't match then we'll try to use ssh to
check whether the storage is actually shared or not.

If ssh keys are not set up between the compute nodes for the user
running nova-compute then the call to utils.ssh_execute() will fail and
we will return wrong information.

utils.ssh_execute() is also used in _cleanup_remote_migration() and
migrate_disk_and_power_off() and would suffer from similar issues there.

Either we need to ensure that the requirement for pre-sharing the ssh
keys is clearly documented, or we need to convert these to to use RPC
calls like live migration.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: compute

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1459782

Title:
  _is_storage_shared_with() in libvirt/driver.py gives possibly false
  results if ssh keys not configured

Status in OpenStack Compute (Nova):
  New

Bug description:
  In virt.libvirt.driver.LibvirtDriver._is_storage_shared_with() we
  first check IP addresses and if they don't match then we'll try to use
  ssh to check whether the storage is actually shared or not.

  If ssh keys are not set up between the compute nodes for the user
  running nova-compute then the call to utils.ssh_execute() will fail
  and we will return wrong information.

  utils.ssh_execute() is also used in _cleanup_remote_migration() and
  migrate_disk_and_power_off() and would suffer from similar issues
  there.

  Either we need to ensure that the requirement for pre-sharing the ssh
  keys is clearly documented, or we need to convert these to to use RPC
  calls like live migration.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1459782/+subscriptions


Follow ups

References