yahoo-eng-team team mailing list archive

[Tyr Johanson <tyr@xxxxxx>]

Public bug reported:

I noticed that openstack_dashboard/test/jasmine_test.py was not actually
referenced (i.e. adding tests to it didn't cause the tests to be
executed).

This patch kindly removed the unused file.
https://review.openstack.org/#/c/182786/

Now that _scripts.html has been untangled by a source re-organization,
we have a way for openstack_dashboard to include .js files that are
common to multiple dashboards. See
https://review.openstack.org/#/c/185140/.

For files that are ONLY used by one dashboard, the source and .spec
files can be included from the enabled/_XX_abc.py files. However, for
files that are common to multiple dashboards (like the API) I think we
want a higher level openstack_dashboard/test/jasmine_tests.py to pull in
test code common to multiple dashboards (so that it doesn't need to be
duplicated in multiple enabled/* files.

See also this patch which attempted to synchronize the jasmine_tests.py
files (before one was removed).

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1460137

Title:
  Need openstack_dashboard/test/jasmine_test.py

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  I noticed that openstack_dashboard/test/jasmine_test.py was not
  actually referenced (i.e. adding tests to it didn't cause the tests to
  be executed).

  This patch kindly removed the unused file.
  https://review.openstack.org/#/c/182786/

  Now that _scripts.html has been untangled by a source re-organization,
  we have a way for openstack_dashboard to include .js files that are
  common to multiple dashboards. See
  https://review.openstack.org/#/c/185140/.

  For files that are ONLY used by one dashboard, the source and .spec
  files can be included from the enabled/_XX_abc.py files. However, for
  files that are common to multiple dashboards (like the API) I think we
  want a higher level openstack_dashboard/test/jasmine_tests.py to pull
  in test code common to multiple dashboards (so that it doesn't need to
  be duplicated in multiple enabled/* files.

  See also this patch which attempted to synchronize the
  jasmine_tests.py files (before one was removed).

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1460137/+subscriptions