← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1463651] [NEW] test_get_guest_config_os_command_empty fails with the new ImageMetaProps object

 

Public bug reported:

test_get_guest_config_os_command_empty is incompatible with the new
ImageMetaProps object, as empty values are not for os_command_line field
are not allowed.

Traceback (most recent call last):
File "nova/tests/unit/virt/libvirt/test_driver.py", line 3809, in test_get_guest_config_os_command_empty
 image_meta, disk_info)
File "nova/virt/libvirt/driver.py", line 4172, in _get_guest_config
 flavor, virt_type)
File "nova/virt/libvirt/vif.py", line 378, in get_config
  inst_type, virt_type)
File "nova/virt/libvirt/vif.py", line 162, in get_config_bridge
  inst_type, virt_type)
File "nova/virt/libvirt/vif.py", line 111, in get_base_config
  use_osinfo).network_model
File "nova/virt/osinfo.py", line 119, in __init__
  image_meta = objects.ImageMeta.from_dict(image_meta)
File "nova/objects/image_meta.py", line 80, in from_dict
  image_meta.get("properties", {}))
File "nova/objects/image_meta.py", line 382, in from_dict
  obj._set_attr_from_current_names(image_props)
File "nova/objects/image_meta.py", line 362, in _set_attr_from_current_names
  setattr(self, key, image_props[key])
File "nova/objects/base.py", line 74, in setter
  field_value = field.coerce(self, name, value)
File "nova/objects/fields.py", line 201, in coerce
  return self._null(obj, attr)
File "nova/objects/fields.py", line 179, in _null
  raise ValueError(_("Field `%s' cannot be None") % attr)
ValueError: Field `os_command_line' cannot be None

** Affects: nova
     Importance: Undecided
     Assignee: Vladik Romanovsky (vladik-romanovsky)
         Status: In Progress


** Tags: libvirt

** Changed in: nova
     Assignee: (unassigned) => Vladik Romanovsky (vladik-romanovsky)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1463651

Title:
  test_get_guest_config_os_command_empty fails with the new
  ImageMetaProps object

Status in OpenStack Compute (Nova):
  In Progress

Bug description:
  test_get_guest_config_os_command_empty is incompatible with the new
  ImageMetaProps object, as empty values are not for os_command_line field
  are not allowed.

  Traceback (most recent call last):
  File "nova/tests/unit/virt/libvirt/test_driver.py", line 3809, in test_get_guest_config_os_command_empty
   image_meta, disk_info)
  File "nova/virt/libvirt/driver.py", line 4172, in _get_guest_config
   flavor, virt_type)
  File "nova/virt/libvirt/vif.py", line 378, in get_config
    inst_type, virt_type)
  File "nova/virt/libvirt/vif.py", line 162, in get_config_bridge
    inst_type, virt_type)
  File "nova/virt/libvirt/vif.py", line 111, in get_base_config
    use_osinfo).network_model
  File "nova/virt/osinfo.py", line 119, in __init__
    image_meta = objects.ImageMeta.from_dict(image_meta)
  File "nova/objects/image_meta.py", line 80, in from_dict
    image_meta.get("properties", {}))
  File "nova/objects/image_meta.py", line 382, in from_dict
    obj._set_attr_from_current_names(image_props)
  File "nova/objects/image_meta.py", line 362, in _set_attr_from_current_names
    setattr(self, key, image_props[key])
  File "nova/objects/base.py", line 74, in setter
    field_value = field.coerce(self, name, value)
  File "nova/objects/fields.py", line 201, in coerce
    return self._null(obj, attr)
  File "nova/objects/fields.py", line 179, in _null
    raise ValueError(_("Field `%s' cannot be None") % attr)
  ValueError: Field `os_command_line' cannot be None

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1463651/+subscriptions


Follow ups

References