yahoo-eng-team team mailing list archive

[Charles V Bock <Charles.V.Bock@xxxxxxxxx>]

Public bug reported:

The integration tests use a navigation menu structure to create go_to_ functions for each page path.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L49
https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L257

Unfortunately it only uses the last two segments of the path to generate
the name resulting in an overwrite of previously defined functions.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L279


Ex:
[Project/Compute/Volumes/Volumes] creates:
go_to_volumes_volumespage
https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L69

Which is the same as....

[Admin/System/Volumes/Volumes] creates:
go_to_volumes_volumespage
https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L146


This causes issues when trying to generate tests for volumes or any other conflicting pair.

Thanks.

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1467615

Title:
  Integration test navigation overwrites itself.

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  The integration tests use a navigation menu structure to create go_to_ functions for each page path.
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L49
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L257

  Unfortunately it only uses the last two segments of the path to
  generate the name resulting in an overwrite of previously defined
  functions.

  https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L279

  
  Ex:
  [Project/Compute/Volumes/Volumes] creates:
  go_to_volumes_volumespage
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L69

  Which is the same as....

  [Admin/System/Volumes/Volumes] creates:
  go_to_volumes_volumespage
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L146

  
  This causes issues when trying to generate tests for volumes or any other conflicting pair.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1467615/+subscriptions