yahoo-eng-team team mailing list archive

[Daisuke Fujita <fuzita.daisuke@xxxxxxxxxxxxxx>]

Public bug reported:

The followings are needed to confirm the resource update history.
 *Latest value
 *Updated value(point)
 *Default value

Latest value is got by "GET" API.
**GET API**
$ curl -X GET -H "X-Auth-Token: $TOKEN"  http://192.168.122.141:9696/v2.0/networks/e6e81e5a-9706-4e33-a6e4-4e63cc152a3a | jq .
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   374  100   374    0     0  22034      0 --:--:-- --:--:-- --:--:-- 24933
{
  "network": {
    "provider:segmentation_id": 1013,
    "id": "e6e81e5a-9706-4e33-a6e4-4e63cc152a3a",
    "mtu": 0,
    "port_security_enabled": true,
    "shared": false,
    "status": "ACTIVE",
    "subnets": [],
    "name": "test-002",
    "provider:physical_network": null,
    "router:external": false,
    "tenant_id": "0862ba8c3497455a8fdf40c49f0f2644",
    "admin_state_up": true,
    "provider:network_type": "vxlan"
  }
}
$

And, Updated value is logged as "Request body:" when resource is updated.
**PUT API**
$ curl -X PUT -d '{"network":{"name":"test-002"}}' -H "X-Auth-Token: $TOKEN"  -H "Content-Type: application/json" http://192.168.122.141:9696/v2.0/networks/e6e81e5a-9706-4e33-a6e4-4e63cc152a3a

**log**
2015-07-03 15:35:43.870 DEBUG neutron.api.v2.base [req-a45f50ab-2606-4f00-9e35-bcdec16ae3a7 admin 0862ba8c3497455a8fdf40c49f0f2644] Request body: {u'network': {u'name': u'test-002'}} from (pid=2084) prepare_request_body /opt/stack/neutron/neutron/api/v2/base.py:598

But, Default value is not logged.

If many resources has been updated in many times, user cannot determine about following.
 *What is the original value of a changed value?
That is not useful in all project.

This patch will log Default value when new resource is created.

Followings are sample that Default value logged as "Response body:"
**POST API**
$ curl -X POST  -d '{"network":{"name":"test-001"}}' -H "X-Auth-Token: $TOKEN"  -H "Content-Type: application/json" http://192.168.122.141:9696/v2.0/networks

**log**
2015-07-03 15:30:48.835 INFO neutron.api.v2.resource [req-356f5432-a525-4d60-92f8-e760febe2865 admin 0862ba8c3497455a8fdf40c49f0f2644] Response body: {u'network': {u'status': u'ACTIVE', u'subnets': [], u'name': u'test-001', u'provider:physical_network': None, u'router:external': False, u'tenant_id': u'0862ba8c3497455a8fdf40c49f0f2644', u'admin_state_up': True, u'provider:network_type': u'vxlan', u'port_security_enabled': True, u'shared': False, u'mtu': 0, u'id': u'e6e81e5a-9706-4e33-a6e4-4e63cc152a3a', u'provider:segmentation_id': 1013}}

** Affects: neutron
     Importance: Undecided
     Assignee: Daisuke Fujita (fuzita-daisuke)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Daisuke Fujita (fuzita-daisuke)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1471200

Title:
  Resource update history is not clear

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  The followings are needed to confirm the resource update history.
   *Latest value
   *Updated value(point)
   *Default value

  Latest value is got by "GET" API.
  **GET API**
  $ curl -X GET -H "X-Auth-Token: $TOKEN"  http://192.168.122.141:9696/v2.0/networks/e6e81e5a-9706-4e33-a6e4-4e63cc152a3a | jq .
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100   374  100   374    0     0  22034      0 --:--:-- --:--:-- --:--:-- 24933
  {
    "network": {
      "provider:segmentation_id": 1013,
      "id": "e6e81e5a-9706-4e33-a6e4-4e63cc152a3a",
      "mtu": 0,
      "port_security_enabled": true,
      "shared": false,
      "status": "ACTIVE",
      "subnets": [],
      "name": "test-002",
      "provider:physical_network": null,
      "router:external": false,
      "tenant_id": "0862ba8c3497455a8fdf40c49f0f2644",
      "admin_state_up": true,
      "provider:network_type": "vxlan"
    }
  }
  $

  And, Updated value is logged as "Request body:" when resource is updated.
  **PUT API**
  $ curl -X PUT -d '{"network":{"name":"test-002"}}' -H "X-Auth-Token: $TOKEN"  -H "Content-Type: application/json" http://192.168.122.141:9696/v2.0/networks/e6e81e5a-9706-4e33-a6e4-4e63cc152a3a

  **log**
  2015-07-03 15:35:43.870 DEBUG neutron.api.v2.base [req-a45f50ab-2606-4f00-9e35-bcdec16ae3a7 admin 0862ba8c3497455a8fdf40c49f0f2644] Request body: {u'network': {u'name': u'test-002'}} from (pid=2084) prepare_request_body /opt/stack/neutron/neutron/api/v2/base.py:598

  But, Default value is not logged.

  If many resources has been updated in many times, user cannot determine about following.
   *What is the original value of a changed value?
  That is not useful in all project.

  This patch will log Default value when new resource is created.

  Followings are sample that Default value logged as "Response body:"
  **POST API**
  $ curl -X POST  -d '{"network":{"name":"test-001"}}' -H "X-Auth-Token: $TOKEN"  -H "Content-Type: application/json" http://192.168.122.141:9696/v2.0/networks

  **log**
  2015-07-03 15:30:48.835 INFO neutron.api.v2.resource [req-356f5432-a525-4d60-92f8-e760febe2865 admin 0862ba8c3497455a8fdf40c49f0f2644] Response body: {u'network': {u'status': u'ACTIVE', u'subnets': [], u'name': u'test-001', u'provider:physical_network': None, u'router:external': False, u'tenant_id': u'0862ba8c3497455a8fdf40c49f0f2644', u'admin_state_up': True, u'provider:network_type': u'vxlan', u'port_security_enabled': True, u'shared': False, u'mtu': 0, u'id': u'e6e81e5a-9706-4e33-a6e4-4e63cc152a3a', u'provider:segmentation_id': 1013}}

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1471200/+subscriptions