← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1471967] [NEW] Fernet unit tests do not test persistence logic

 

Public bug reported:

There are some unit tests for the Fernet token provider that live
outside of the functional-like tests (test_v3_auth.py, for example) [0].
These tests should include a test to assert that the Fernet token
provider returns False when asked if it's tokens need persistence [1].


[0] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/tests/unit/token/test_fernet_provider.py
[1] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/token/providers/fernet/core.py#L36-L38

** Affects: keystone
     Importance: Undecided
     Assignee: Lance Bragstad (lbragstad)
         Status: In Progress


** Tags: fernet test-improvement

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1471967

Title:
  Fernet unit tests do not test persistence logic

Status in OpenStack Identity (Keystone):
  In Progress

Bug description:
  There are some unit tests for the Fernet token provider that live
  outside of the functional-like tests (test_v3_auth.py, for example)
  [0]. These tests should include a test to assert that the Fernet token
  provider returns False when asked if it's tokens need persistence [1].


  [0] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/tests/unit/token/test_fernet_provider.py
  [1] https://github.com/openstack/keystone/blob/992d9ecbf4f563c42848147d4d66f8ec8efd4df0/keystone/token/providers/fernet/core.py#L36-L38

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1471967/+subscriptions


Follow ups

References