← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1476931] [NEW] monkey_patch broken

 

Public bug reported:

With monkey_patch enabled, it would patch specified modules with
decorator to trace all the function call. But it broken by some minor
bugs:

=============================bug 1============================================
2015-07-21 09:52:16.707 TRACE nova   File "/opt/stack/nova/nova/api/ec2/__init__.py", line 349, in __init__
2015-07-21 09:52:16.707 TRACE nova     self.controller = importutils.import_object(controller)
2015-07-21 09:52:16.707 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 38, in import_object
2015-07-21 09:52:16.707 TRACE nova     return import_class(import_str)(*args, **kwargs)
2015-07-21 09:52:16.707 TRACE nova   File "/opt/stack/nova/nova/notifications.py", line 89, in wrapped_func
2015-07-21 09:52:16.707 TRACE nova     method = notifier.getattr(CONF.default_notification_level.lower(),
2015-07-21 09:52:16.707 TRACE nova AttributeError: '_SubNotifier' object has no attribute 'getattr'
2015-07-21 09:52:16.707 TRACE nova

=============================bug 2==========================================
2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 38, in import_object
2015-07-21 09:56:51.836 TRACE nova     return import_class(import_str)(*args, **kwargs)
2015-07-21 09:56:51.836 TRACE nova   File "/opt/stack/nova/nova/notifications.py", line 91, in wrapped_func
2015-07-21 09:56:51.836 TRACE nova     method(ctxt, name, body)
2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 228, in info
2015-07-21 09:56:51.836 TRACE nova     self._notify(ctxt, event_type, payload, 'INFO')
2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 309, in _notify
2015-07-21 09:56:51.836 TRACE nova     super(_SubNotifier, self)._notify(ctxt, event_type, payload, priority)
2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 168, in _notify
2015-07-21 09:56:51.836 TRACE nova     ctxt = self._serializer.serialize_context(ctxt)
2015-07-21 09:56:51.836 TRACE nova   File "/opt/stack/nova/nova/rpc.py", line 114, in serialize_context
2015-07-21 09:56:51.836 TRACE nova     return context.to_dict()
2015-07-21 09:56:51.836 TRACE nova AttributeError: 'NoneType' object has no attribute 'to_dict'

** Affects: nova
     Importance: Undecided
     Assignee: Zhai, Edwin (edwin-zhai)
         Status: In Progress

** Changed in: nova
     Assignee: (unassigned) => Zhai, Edwin (edwin-zhai)

** Changed in: nova
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1476931

Title:
  monkey_patch broken

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  With monkey_patch enabled, it would patch specified modules with
  decorator to trace all the function call. But it broken by some minor
  bugs:

  =============================bug 1============================================
  2015-07-21 09:52:16.707 TRACE nova   File "/opt/stack/nova/nova/api/ec2/__init__.py", line 349, in __init__
  2015-07-21 09:52:16.707 TRACE nova     self.controller = importutils.import_object(controller)
  2015-07-21 09:52:16.707 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 38, in import_object
  2015-07-21 09:52:16.707 TRACE nova     return import_class(import_str)(*args, **kwargs)
  2015-07-21 09:52:16.707 TRACE nova   File "/opt/stack/nova/nova/notifications.py", line 89, in wrapped_func
  2015-07-21 09:52:16.707 TRACE nova     method = notifier.getattr(CONF.default_notification_level.lower(),
  2015-07-21 09:52:16.707 TRACE nova AttributeError: '_SubNotifier' object has no attribute 'getattr'
  2015-07-21 09:52:16.707 TRACE nova

  =============================bug 2==========================================
  2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_utils/importutils.py", line 38, in import_object
  2015-07-21 09:56:51.836 TRACE nova     return import_class(import_str)(*args, **kwargs)
  2015-07-21 09:56:51.836 TRACE nova   File "/opt/stack/nova/nova/notifications.py", line 91, in wrapped_func
  2015-07-21 09:56:51.836 TRACE nova     method(ctxt, name, body)
  2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 228, in info
  2015-07-21 09:56:51.836 TRACE nova     self._notify(ctxt, event_type, payload, 'INFO')
  2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 309, in _notify
  2015-07-21 09:56:51.836 TRACE nova     super(_SubNotifier, self)._notify(ctxt, event_type, payload, priority)
  2015-07-21 09:56:51.836 TRACE nova   File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/notify/notifier.py", line 168, in _notify
  2015-07-21 09:56:51.836 TRACE nova     ctxt = self._serializer.serialize_context(ctxt)
  2015-07-21 09:56:51.836 TRACE nova   File "/opt/stack/nova/nova/rpc.py", line 114, in serialize_context
  2015-07-21 09:56:51.836 TRACE nova     return context.to_dict()
  2015-07-21 09:56:51.836 TRACE nova AttributeError: 'NoneType' object has no attribute 'to_dict'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1476931/+subscriptions


Follow ups