yahoo-eng-team team mailing list archive

[jiaxi <jiaxi@xxxxxxxxxxxxxxx>]

Public bug reported:

keystone/backends.py

 39     _IDENTITY_API = identity.Manager()
 40     _ASSIGNMENT_API = assignment.Manager()                                                                              
 41                            
 42     DRIVERS = dict(        
 43         assignment_api=_ASSIGNMENT_API, 
 44         catalog_api=catalog.Manager(),  
 45         credential_api=credential.Manager(),
 46         domain_config_api=resource.DomainConfigManager(),
 47         endpoint_filter_api=endpoint_filter.Manager(),
 48         endpoint_policy_api=endpoint_policy.Manager(),
 49         federation_api=federation.Manager(),
 50         id_generator_api=identity.generator.Manager(),
 51         id_mapping_api=identity.MappingManager(),
 52         identity_api=_IDENTITY_API,    

There is no need to name two const _IDENTITY_API and _ASSIGNMENT_API,

should change into

 42     DRIVERS = dict(        
 43         assignment_api= identity.Manager(), 
 44         catalog_api=catalog.Manager(),  
 45         credential_api=credential.Manager(),
 46         domain_config_api=resource.DomainConfigManager(),
 47         endpoint_filter_api=endpoint_filter.Manager(),
 48         endpoint_policy_api=endpoint_policy.Manager(),
 49         federation_api=federation.Manager(),
 50         id_generator_api=identity.generator.Manager(),
 51         id_mapping_api=identity.MappingManager(),
 52         identity_api=assignment.Manager(),

** Affects: keystone
     Importance: Undecided
         Status: Invalid

** Changed in: keystone
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1476965

Title:
  keystone/backends.py two lines should be deleted

Status in Keystone:
  Invalid

Bug description:
  keystone/backends.py

   39     _IDENTITY_API = identity.Manager()
   40     _ASSIGNMENT_API = assignment.Manager()                                                                              
   41                            
   42     DRIVERS = dict(        
   43         assignment_api=_ASSIGNMENT_API, 
   44         catalog_api=catalog.Manager(),  
   45         credential_api=credential.Manager(),
   46         domain_config_api=resource.DomainConfigManager(),
   47         endpoint_filter_api=endpoint_filter.Manager(),
   48         endpoint_policy_api=endpoint_policy.Manager(),
   49         federation_api=federation.Manager(),
   50         id_generator_api=identity.generator.Manager(),
   51         id_mapping_api=identity.MappingManager(),
   52         identity_api=_IDENTITY_API,    

  There is no need to name two const _IDENTITY_API and _ASSIGNMENT_API,

  should change into

   42     DRIVERS = dict(        
   43         assignment_api= identity.Manager(), 
   44         catalog_api=catalog.Manager(),  
   45         credential_api=credential.Manager(),
   46         domain_config_api=resource.DomainConfigManager(),
   47         endpoint_filter_api=endpoint_filter.Manager(),
   48         endpoint_policy_api=endpoint_policy.Manager(),
   49         federation_api=federation.Manager(),
   50         id_generator_api=identity.generator.Manager(),
   51         id_mapping_api=identity.MappingManager(),
   52         identity_api=assignment.Manager(),

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1476965/+subscriptions