yahoo-eng-team team mailing list archive

[Darragh O'Reilly <1478531@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

https://github.com/openstack/neutron/blob/801dedebbfc7ff4ae6421c793a1154ca0d169e6c/neutron/tests/functional/scheduler/test_dhcp_agent_scheduler.py#L394-L396


        for hosted_net_id in hosted_net_ids:
            self.assertIn(hosted_net_id, expected_hosted_networks,
                          message=msg + '[%s]' % hosted_net_id)


this will always pass because hosted_net_ids is always a sub-list of expected_hosted_networks, even if the method under test doesn't do what it's supposed to. 

The test should assert that each expected hosted network is in
hosted_net_ids instead.

** Affects: neutron
     Importance: Undecided
     Assignee: Darragh O'Reilly (darragh-oreilly)
         Status: In Progress

** Changed in: neutron
     Assignee: (unassigned) => Darragh O'Reilly (darragh-oreilly)

** Changed in: neutron
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1478531

Title:
  Functional test for dhcp autoschedule does not check properly

Status in neutron:
  In Progress

Bug description:
  https://github.com/openstack/neutron/blob/801dedebbfc7ff4ae6421c793a1154ca0d169e6c/neutron/tests/functional/scheduler/test_dhcp_agent_scheduler.py#L394-L396

  
          for hosted_net_id in hosted_net_ids:
              self.assertIn(hosted_net_id, expected_hosted_networks,
                            message=msg + '[%s]' % hosted_net_id)

  
  this will always pass because hosted_net_ids is always a sub-list of expected_hosted_networks, even if the method under test doesn't do what it's supposed to. 

  The test should assert that each expected hosted network is in
  hosted_net_ids instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1478531/+subscriptions