yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #36018
[Bug 1479172] [NEW] Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick
Public bug reported:
With change https://review.openstack.org/#/c/175569/ we lost some unit
test coverage of connect_volume/disconnect_volume/get_config methods in
the libvirt iscsi/fibrechannel/iser/aoe volume drivers, since the actual
low-level parts of those are now handled in os-brick but we still need
to unit test the calls to os-brick in nova.
I've made comments in https://review.openstack.org/#/c/175569/ where
there were things that didn't have test coverage after the change. Some
of the other comments are handled in the refactor series here:
https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp
/consolidate-libvirt-fs-volume-drivers,n,z
** Affects: nova
Importance: Low
Status: Confirmed
** Tags: libvirt low-hanging-fruit testing volumes
** Changed in: nova
Status: New => Confirmed
** Changed in: nova
Importance: Undecided => Low
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1479172
Title:
Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers
after os-brick
Status in OpenStack Compute (nova):
Confirmed
Bug description:
With change https://review.openstack.org/#/c/175569/ we lost some unit
test coverage of connect_volume/disconnect_volume/get_config methods
in the libvirt iscsi/fibrechannel/iser/aoe volume drivers, since the
actual low-level parts of those are now handled in os-brick but we
still need to unit test the calls to os-brick in nova.
I've made comments in https://review.openstack.org/#/c/175569/ where
there were things that didn't have test coverage after the change.
Some of the other comments are handled in the refactor series here:
https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp
/consolidate-libvirt-fs-volume-drivers,n,z
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1479172/+subscriptions
Follow ups