← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1490628] [NEW] Dashboard Panels should not include SCSS

 

Public bug reported:

Currently the following SCSS is included in Dashboard Panels  -
project.scss and identity.scss

// Custom Theme Variables
@import "/custom/variables";
@import "/dashboard/scss/variables";

// Custom Style Variables
@import "/custom/styles";

This introduces multiple inclusion. Instead this needs to be only done
in app.scss.

Additionally, the StaticFileFinder already does find the SCSS files for
the dashboards so the inclusion in

_1000_project.py
and
_3000_identity.py 

is not required.

** Affects: horizon
     Importance: Undecided
     Assignee: Rajat Vig (rajatv)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1490628

Title:
  Dashboard Panels should not include SCSS

Status in OpenStack Dashboard (Horizon):
  In Progress

Bug description:
  Currently the following SCSS is included in Dashboard Panels  -
  project.scss and identity.scss

  // Custom Theme Variables
  @import "/custom/variables";
  @import "/dashboard/scss/variables";

  // Custom Style Variables
  @import "/custom/styles";

  This introduces multiple inclusion. Instead this needs to be only done
  in app.scss.

  Additionally, the StaticFileFinder already does find the SCSS files
  for the dashboards so the inclusion in

  _1000_project.py
  and
  _3000_identity.py 

  is not required.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1490628/+subscriptions


Follow ups